Turn off transformation for closures inside loops. #6480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
no_closure_inside_loop
branch
from
fa2d150
to
9491fd9
Compare
|
Tests look fine after rebasing on top of #6102 |
cristianoc
force-pushed
the
let
branch
4 times, most recently
from
075719b
to
c52d009
Compare
cristianoc
force-pushed
the
no_closure_inside_loop
branch
from
9491fd9
to
10fd84f
Compare
cristianoc
force-pushed
the
no_closure_inside_loop
branch
from
10fd84f
to
9906f19
Compare
The scope of `var` is per-function, requiring a transformation for closures inside loops when capturing loop variables. This PR turns off the transformation.
cristianoc
force-pushed
the
no_closure_inside_loop
branch
from
9906f19
to
1f8af1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope of
varis per-function, requiring a transformation for closures inside loops when capturing loop variables. This PR turns off the transformation.This PR should go after #6102