GenType: ensure JS import works regardless moduleResolution
#6541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I and @fhammerschmidt discussed in fhammerschmidt/rescript-lang.org#1
This is a necessary change as we want to use the
.res.js
suffix instead of.bs.js
. This is becauseimport './Module.res'
will be resolved as the original ReScript file instead of the generatedModule.res.js
file.In #6182, I differentiated the case when
moduleResolution: node
to minimize output changes, but in fact, it is preferable always to use the full path if possible.I added
ModuleResolution1.res
andModuleResolution2.res
tests to ensure that themoduleResolution
option still applies to type import. But as they are always type-only modules since v11, themoduleResolution
option doesn't make much sense anymore. This option should be removed again after the breaking change in #6196.