No empty export dump #6744
Merged
No empty export dump #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DZakh
commented
Apr 28, 2024
DZakh
commented
DZakh
commented
Apr 28, 2024
| @@ -70,7 +70,11 @@ let exports cxt f (idents : Ident.t list) = | |||
|
|
|||
| (** Print module in ES6 format, it is ES6, trailing comma is valid ES6 code *) | |||
| let es6_export cxt f (idents : Ident.t list) = | |||
| let outer_cxt, reversed_list = | |||
| P.at_least_two_lines f; | |||
There was a problem hiding this comment.
I don't really like to add a new line when there is no other output here, but that's the best way I could come up with to keep the /* Not a pure module */ comment display in a good way.
|
Very nice, I've thought about this before too 👍 |
|
It's kind of fun (and easy) to fix js dump issues, so I think I'd like to continue and fix them all 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.