Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add -nostdlib option and make it actually do something #6824

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jun 23, 2024

In #6778, I removed the -nostdlib option because it did not have any effect anymore after the cmi cache was removed.

However, when building the standard library from scratch, it is actually very helpful to have a command line option that ensures that we do not inadvertently use pre-existing cmi files from the lib/ocaml directory. This is especially true for our work in integrating Core into the compiler repo and building all libs with rewatch.

I have therefore re-added the option and am now taking it into account in the initialization of Config.load_path so that the lib/ocaml directory is omitted from the load path if the option is set.

@cknitt cknitt requested review from cristianoc and zth June 23, 2024 09:15
@cknitt cknitt merged commit 1fba8ef into rescript-lang:master Jun 26, 2024
19 checks passed
@cknitt cknitt deleted the no-stdlib-back-again branch June 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants