Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert js.ml files to .res. #6835

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Convert js.ml files to .res. #6835

merged 1 commit into from
Jul 2, 2024

Conversation

cristianoc
Copy link
Collaborator

@cristianoc cristianoc commented Jun 27, 2024

These are the last two .ml files.

@cristianoc
Copy link
Collaborator Author

cristianoc commented Jul 2, 2024

@cknitt there are changes in the ninjas, but these js.ml files are special anyway. Perhaps if issues arise before they're completely removed with the new build, one can special case them if really necessary.

@cknitt
Copy link
Member

cknitt commented Jul 2, 2024

@cknitt there are changes in the ninjas, but these js.ml files are special anyway. Perhaps if issues arise before they're completely removed with the new build, one can special case them if really necessary.

Ok, then let's go ahead with this!

@cristianoc cristianoc changed the title Test converting js.ml files to .res. Convert js.ml files to .res. Jul 2, 2024
@cristianoc cristianoc merged commit 4d9456f into master Jul 2, 2024
19 checks passed
@cristianoc cristianoc deleted the js_res branch July 2, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants