Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deno compatibility issues on Windows #6850

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

rlidwka
Copy link
Contributor

@rlidwka rlidwka commented Jul 3, 2024

Rescript fails to start at the moment, if launched with specifically Deno on specifically Windows:

PS C:\Users\user> deno run -A npm:rescript
error: Uncaught TypeError: Windows only supports ctrl-c (SIGINT) and ctrl-break (SIGBREAK).
    at bindSignal (ext:runtime/40_signals.js:14:10)
    at Object.addSignalListener (ext:runtime/40_signals.js:54:19)
    at Process.on (node:process:349:12)
    at Object.<anonymous> (file:///C:/Users/user/rust/rescript-compiler/node_modules/.deno/rescript@11.1.2/node_modules/rescript/rescript:64:9)
    at Object.<anonymous> (file:///C:/Users/user/rust/rescript-compiler/node_modules/.deno/rescript@11.1.2/node_modules/rescript/rescript:133:4)

The reason is: denoland/deno#9995

I've tested it locally (with some trickery required to run commonjs from local fs), so after adding try..catch rescript runs correctly.

Signed-off-by: Alex Kocharin <alex@kocharin.ru>
@fhammerschmidt
Copy link
Member

Looks fine.

@cknitt we probably want to include this in 11.1.3 as well

@fhammerschmidt fhammerschmidt merged commit 5d1e25f into rescript-lang:master Jul 4, 2024
19 checks passed
fhammerschmidt added a commit that referenced this pull request Jul 4, 2024
fhammerschmidt added a commit that referenced this pull request Jul 4, 2024
@fhammerschmidt fhammerschmidt added this to the v11.1.3 milestone Jul 9, 2024
cknitt pushed a commit to cknitt/rescript-compiler that referenced this pull request Jul 26, 2024
Signed-off-by: Alex Kocharin <alex@kocharin.ru>
cknitt pushed a commit to cknitt/rescript-compiler that referenced this pull request Jul 26, 2024
cknitt pushed a commit to cknitt/rescript-compiler that referenced this pull request Jul 26, 2024
Signed-off-by: Alex Kocharin <alex@kocharin.ru>
cknitt pushed a commit to cknitt/rescript-compiler that referenced this pull request Jul 26, 2024
cknitt pushed a commit that referenced this pull request Jul 26, 2024
Signed-off-by: Alex Kocharin <alex@kocharin.ru>
cknitt pushed a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants