Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ml support #6852

Merged
merged 11 commits into from
Jul 4, 2024
Merged

Remove ml support #6852

merged 11 commits into from
Jul 4, 2024

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc
Copy link
Collaborator Author

@cknitt would you have a look at this commit: 66803b9

It removes ocaml support from the playground. I don't think the playground currently does anything with ocaml, but I'd like to make sure that we're not breaking some interface the playground is using.

@cknitt
Copy link
Member

cknitt commented Jul 4, 2024

@fhammerschmidt just told me that it might be necessary to increment the api_version at the start of jscomp/jsoo/jsoo_playground_main.ml.
Other than that I don't see anything problematic, but we'll only know for sure once we try it. :-)
Maybe we should do an alpha.1 soon, then the playground will also be deployed.

@cristianoc
Copy link
Collaborator Author

@fhammerschmidt just told me that it might be necessary to increment the api_version at the start of jscomp/jsoo/jsoo_playground_main.ml. Other than that I don't see anything problematic, but we'll only know for sure once we try it. :-) Maybe we should do an alpha.1 soon, then the playground will also be deployed.

Done

@cristianoc cristianoc requested a review from cknitt July 4, 2024 11:06
@cristianoc cristianoc merged commit 0b97385 into master Jul 4, 2024
19 checks passed
@cristianoc cristianoc deleted the remove_ml_support branch July 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants