Ignore @uncurry attribute in uncurried mode.
#6869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
ignore-uncurry-attribute
branch
from
cb4dc16
to
9539322
Compare
cristianoc
commented
Jul 10, 2024
| let Curry = require("../../lib/js/curry.js"); | ||
|
|
||
| function map1(prim0, prim1) { | ||
| return map(prim0, Curry.__1(prim1)); |
There was a problem hiding this comment.
It's puzzling that the @uncurry attribute has the opposite effect of what's supposed to do on this example, but that's the reason for this PR.
Turns out that `@uncurry` attribute even in uncurried mode can produce js code that used`Curry`. The `@uncurry` attribute will be deprecated. For now, this PR ignores it.
cristianoc
force-pushed
the
ignore-uncurry-attribute
branch
from
9539322
to
6f58e18
Compare
zth
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that
@uncurryattribute even in uncurried mode can produce js code that usedCurry. The@uncurryattribute will be deprecated.For now, this PR ignores it.