Force regenerate build.ninja

[aspeddro]

Tested at https://github.com/aspeddro/rescript-test-build-warn-error/actions/runs/9925284243/job/27417532450

npm-packages.zip downloaded here

Close #6868

[aspeddro]

@cknitt you can test it?

[cknitt]

@cknitt you can test it?

Thanks a lot! Will test today.

[cknitt]

Tested and works fine for me! 🎉

[cknitt]

Could you do the PR against master?
(I will later backport it to 11.0-release together with other fixes.)

[aspeddro]

Base now is master. CHANGELOG updated

[cknitt]

Thanks a lot!

I was asking myself if we should further improve this to keep the existing optimization as far as possible (only regenerate build.ninja when needed). Then we would have to remember what -warn-error was set to the last time the build.ninja was generated and extend Bsb_ninja_check.check accordingly.

Right now it is regenerated on every build, so this means if I run rescript -w it will be regenerated on every change, correct?

[aspeddro]

Right now it is regenerated on every build, so this means if I run rescript -w it will be regenerated on every change, correct?

Yes!!

I believe there is an effect on performance. It will run this on every build

https://github.com/rescript-lang/rescript-compiler/blob/e0aac3867f89b2b15cc02c1725dc9600a162c94f/jscomp/bsb/bsb_ninja_regen.ml#L44-L100

Another option is to force a cleanup after using -warn-error, see #6868 (comment)

[cknitt]

I was asking myself if we should further improve this to keep the existing optimization as far as possible (only regenerate build.ninja when needed). Then we would have to remember what -warn-error was set to the last time the build.ninja was generated and extend Bsb_ninja_check.check accordingly.

@aspeddro Could you investigate how hard it is to do this?

[aspeddro]

I saved the information in .bsdeps metadata file. The fourth line indicate the latest -warn-error argument. Is zero (0) when you run without -warn-error argument. It's filled with the value passed in the argument. Then we check if there was a change

12.0.0-alpha.1
/home/pedro/Desktop/projects/rescript-compiler/jscomp/build_tests/build_warn_as_error
0
0
rescript.json	0x1.996370153bbc3p+30
src	0x1.9a4c44902961dp+30
===
/home/pedro/Desktop/projects/rescript-compiler/linux/rescript.exe	0x1.9a6f7d3481b04p+30

When you build with rescript build -warn-error +110

12.0.0-alpha.1
/home/pedro/Desktop/projects/rescript-compiler/jscomp/build_tests/build_warn_as_error
0
+110
rescript.json	0x1.996370153bbc3p+30
src	0x1.9a4c44902961dp+30
===
/home/pedro/Desktop/projects/rescript-compiler/linux/rescript.exe	0x1.9a6f7d3481b04p+30

So:

• A build with -warn-error +110 don't regenerate build.ninja
• A build without -warn-error regenerate build.ninja
• A build with -warn-error +27 regenerate build.ninja

[cknitt]

Awesome work @aspeddro!