Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with uninitialized _param in recursive functions with uni… #6907

Merged
merged 1 commit into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
- Avoid generation of `Curry` with reverse application `|>`. https://github.com/rescript-lang/rescript-compiler/pull/6876
- Fix issue where the internal ppx for pipe `->` would not use uncurried application in uncurried mode. https://github.com/rescript-lang/rescript-compiler/pull/6878
- Fix build after calling without `-warn-error`, see https://github.com/rescript-lang/rescript-compiler/issues/6868 for more details. https://github.com/rescript-lang/rescript-compiler/pull/6877
- Fix issue with uninitialized `_param` in recursive functions with unit argument. https://github.com/rescript-lang/rescript-compiler/pull/6907

#### :house: Internal

Expand Down
1 change: 1 addition & 0 deletions jscomp/core/lam_compile.ml
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ and compile_recursive_let ~all_bindings (cxt : Lam_compile_context.t)
]}
[Alias] may not be exact
*)
let params = if one_unit_arg then [] else params in
let ret : Lam_compile_context.return_label =
{
id;
Expand Down
1 change: 0 additions & 1 deletion jscomp/test/ocaml_re_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion jscomp/test/uncurry_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion lib/es6/stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ function iter(f, strm) {
}
junk(strm);
f(Caml_option.valFromOption(a));
_param = undefined;
continue;
};
};
Expand Down
1 change: 0 additions & 1 deletion lib/js/stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ function iter(f, strm) {
}
junk(strm);
f(Caml_option.valFromOption(a));
_param = undefined;
continue;
};
};
Expand Down