Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix returning object in nested Some #7013

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Fix returning object in nested Some #7013

merged 2 commits into from
Sep 6, 2024

Conversation

cometkim
Copy link
Member

@cometkim cometkim commented Sep 5, 2024

Fixed #7012

@cometkim cometkim requested a review from cknitt September 5, 2024 19:46
cknitt
cknitt approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I'll add the CHANGELOG entry in the PR preparing the alpha.2 release.

@cknitt cknitt merged commit 87374f1 into rescript-lang:master Sep 6, 2024
20 checks passed
@cometkim cometkim deleted the fix-return-obj branch October 24, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrow syntax for anonymous functions produces invalid output
2 participants
@cometkim @cknitt