Build runtime/stdlib files with rescript/bsb instead of ninja.js #7063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the infamous
ninja.js
and instead builds all the runtime/stdlib files using the standard rescript/bsb tooling.For this to work, I had to
-make-runtime
option a littleruntime
)This is the only setup in which I got it to work. But I think that's good enough because
runtime
.All tests are passing, there are no changes to the JS output or the artifact list, and the resulting npm package seems to work fine.