Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build runtime/stdlib files with rescript/bsb instead of ninja.js #7063

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 30, 2024

This removes the infamous ninja.js and instead builds all the runtime/stdlib files using the standard rescript/bsb tooling.

For this to work, I had to

  • tweak the behavior of the existing -make-runtime option a little
  • put all runtime/stdlib files in a single, flat ReScript project (subdirectory runtime)

This is the only setup in which I got it to work. But I think that's good enough because

  1. We will eventually move Belt and Js out to separate packages anyway. So in the end only the actual "runtime" files will remain under runtime.
  2. Next step will be to get it to work with rewatch instead of bsb which may also allow for some further restructuring.

All tests are passing, there are no changes to the JS output or the artifact list, and the resulting npm package seems to work fine.

@cknitt cknitt force-pushed the stdlib branch 5 times, most recently from 6c237c5 to 9eb29bd Compare September 30, 2024 13:13
@cknitt cknitt changed the title WIP: Build runtime/stdlib files with rescript/bsb instead of ninja.js Build runtime/stdlib files with rescript/bsb instead of ninja.js Oct 2, 2024
@cknitt cknitt marked this pull request as ready for review October 2, 2024 14:51
@cknitt cknitt requested review from zth and cometkim October 2, 2024 15:02
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks good, but I'm less familiar with this part, so interested in what @cometkim says.

@cknitt cknitt merged commit d5339a2 into master Oct 2, 2024
20 checks passed
@cknitt cknitt deleted the stdlib branch October 2, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants