Disable -bs-cross-module-opt for tests

[cknitt]

Runtime + tests are currently compiled with -bs-cross-module-opt.

Remove this option so that the way the tests are compiled more closely matches the way real-world code is compiled.

FIXED: When removing this option for the tests, I see some expected changes and some rather surprising ones, like the function Obj.magic suddenly appearing in the JS output.

[cknitt]

I think this may be related to the primitives changes? @cometkim @cristianoc

[cristianoc]

I think this may be related to the primitives changes? @cometkim @cristianoc

Obj.magic is defined as "%identity". If it was defined differently before, then surely the change is the cause for the difference in the generated code.

[cknitt]

There is now this in obj.res:

let magic = Primitive_object_extern.magic

This would need a copy of the external instead.

[cristianoc]

I think we can merge and investigate.
This is a true reflection of what we have in prod.

[cknitt]

I'd prefer to keep this open until the obvious regressions with Obj.magic etc. are sorted out.

[cknitt]

@cometkim I think all primitive_xxx_extern.res need to be removed and their external definitions copied to where they are needed.

[cometkim]

I think all primitive_xxx_extern.res need to be removed and their external definitions copied to where they are needed.

The primitive_xxx_extern.res modules are used to avoid cross-references and unintentional recursive declarations in primitive modules.

They may not be referenced anywhere else, except in exceptional cases such as types.

---

And the only reason I didn't deprecate Obj.magic is because it's heavily used. I don't think it's useful.

[cknitt]

@cometkim See this commit for fixing the output for Obj.magic: e172eb5

What's important is that user code directly uses the externals.

Shall I try to fix all such issues or do you want to do it?

[cometkim]

That fix is what I was expected; As Obj is not a compiler primitive, it should not directly access to xxx_extern modules. What other changes do you expect?

[cknitt]

You are right that we do not need to remove the xxx_extern modules. It is sufficient to get rid of usage like

let magic = Primitive_object_extern.magic

So far I did that for Primitive_object_extern only, but I still need to look at similar usages for the other xxx_extern modules.

[cknitt]

After the fixes, changes look good to me now.

[cristianoc]

sweet