Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support universal dot completion in editor tooling #7226

Merged
merged 7 commits into from
Jan 4, 2025
Merged

Support universal dot completion in editor tooling #7226

merged 7 commits into from
Jan 4, 2025

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 3, 2025

@nojaf nojaf marked this pull request as ready for review January 4, 2025 10:48
zth
zth requested changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Here's a few things we can simply remove since uncurried+curried doesn't exist in this repo.

analysis/src/CompletionBackEnd.ml Outdated Show resolved Hide resolved
analysis/src/CompletionBackEnd.ml Outdated Show resolved Hide resolved
analysis/src/CompletionBackEnd.ml Outdated Show resolved Hide resolved
analysis/src/CompletionBackEnd.ml Outdated Show resolved Hide resolved
analysis/src/CompletionBackEnd.ml Outdated Show resolved Hide resolved
analysis/src/TypeUtils.ml Outdated Show resolved Hide resolved
analysis/src/TypeUtils.ml Outdated Show resolved Hide resolved
analysis/src/TypeUtils.ml Outdated Show resolved Hide resolved
analysis/src/TypeUtils.ml Outdated Show resolved Hide resolved
analysis/src/TypeUtils.ml Outdated Show resolved Hide resolved
@nojaf nojaf requested a review from zth January 4, 2025 16:24
zth
zth approved these changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Maybe add a changelog too? Make it clear it's about the editor tooling, somehow.

@cknitt cknitt changed the title Port PR from rescript-vscode Support universal dot completion in editor tooling Jan 4, 2025
@cknitt cknitt merged commit e5263bd into rescript-lang:master Jan 4, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojaf @zth @cknitt