Analysis tests fixes #7295
Analysis tests fixes #7295
Conversation
| (* regexps *) | ||
| create "%re()" ~insertText:"%re(\"/$0/g\")" ~includesSnippets:true | ||
| create "/<regexp>/g" ~insertText:"/$0/g" ~includesSnippets:true |
There was a problem hiding this comment.
Can do this now since regexp syntax is now 1st class.
| builtInCompletionModules = | ||
| (if | ||
| opens_from_bsc_flags | ||
| |> List.find_opt (fun opn -> | ||
| match opn with | ||
| | ["RescriptCore"] -> true | ||
| | _ -> false) | ||
| |> Option.is_some | ||
| || fst rescriptVersion >= 12 | ||
| then | ||
| { | ||
| arrayModulePath = ["Array"]; | ||
| optionModulePath = ["Option"]; | ||
| stringModulePath = ["String"]; | ||
| intModulePath = ["Int"]; | ||
| floatModulePath = ["Float"]; | ||
| promiseModulePath = ["Promise"]; | ||
| listModulePath = ["List"]; | ||
| resultModulePath = ["Result"]; | ||
| exnModulePath = ["Exn"]; | ||
| regexpModulePath = ["RegExp"]; | ||
| } | ||
| else if | ||
| opens_from_bsc_flags | ||
| |> List.find_opt (fun opn -> | ||
| match opn with | ||
| | ["Belt"] -> true | ||
| | _ -> false) | ||
| |> Option.is_some | ||
| then | ||
| { | ||
| arrayModulePath = ["Array"]; | ||
| optionModulePath = ["Option"]; | ||
| stringModulePath = ["Js"; "String2"]; | ||
| intModulePath = ["Int"]; | ||
| floatModulePath = ["Float"]; | ||
| promiseModulePath = ["Js"; "Promise"]; | ||
| listModulePath = ["List"]; | ||
| resultModulePath = ["Result"]; | ||
| exnModulePath = ["Js"; "Exn"]; | ||
| regexpModulePath = ["Js"; "Re"]; | ||
| } | ||
| else | ||
| { | ||
| arrayModulePath = ["Js"; "Array2"]; | ||
| optionModulePath = ["Belt"; "Option"]; | ||
| stringModulePath = ["Js"; "String2"]; | ||
| intModulePath = ["Belt"; "Int"]; | ||
| floatModulePath = ["Belt"; "Float"]; | ||
| promiseModulePath = ["Js"; "Promise"]; | ||
| listModulePath = ["Belt"; "List"]; | ||
| resultModulePath = ["Belt"; "Result"]; | ||
| exnModulePath = ["Js"; "Exn"]; | ||
| regexpModulePath = ["Js"; "Re"]; | ||
| }); |
There was a problem hiding this comment.
builtInCompletionModules are not needed now that Core is in the compiler repo. But, we are going to make these configurable through the project config soon.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 868774f | Previous: 5d9c682 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run |
1.8970486066666665 ms |
1.3523686533333334 ms |
1.40 |
Print RedBlackTree.res - time/run |
3.305231513333333 ms |
1.98472278 ms |
1.67 |
Print RedBlackTreeNoComments.res - time/run |
3.0024389466666666 ms |
1.8453905533333332 ms |
1.63 |
Parse Napkinscript.res - time/run |
65.50723582666667 ms |
42.23872597333333 ms |
1.55 |
Print Napkinscript.res - time/run |
113.43309909999999 ms |
60.21953604666667 ms |
1.88 |
Parse HeroGraphic.res - time/run |
8.551319106666666 ms |
5.70670238 ms |
1.50 |
Print HeroGraphic.res - time/run |
14.501224480000001 ms |
8.188623 ms |
1.77 |
This comment was automatically generated by workflow using github-action-benchmark.
| XXX Not found! | ||
| [] |
There was a problem hiding this comment.
This change is fine for now. It does highlight a problem, but it's something we'll fix separately.
| ContextPath Value[Int, toString](Nolabel) | ||
| ContextPath Value[Int, toString] | ||
| Path Int.toString | ||
| [] |
There was a problem hiding this comment.
This highlights that we've reduced the scope of the unsaved-completion-inference logic previously for pipes. In practice this does not matter though, because incremental type checking in the editor tooling takes care of this in a much better way.
Will remove these tests in another PR later on, but don't want to touch them for now.
| @@ -1016,7 +1016,7 @@ Package opens Pervasives.JsxModules.place holder | |||
| ContextPath Value[xn] | |||
| Path xn | |||
| [{ | |||
| "label": "Js.Exn.Error(error)", | |||
| "label": "Exn.t.Error(error)", | |||
builtInModulesconfig concept, since Core is now in the compiler repo and Js/Belt is never to be preferred