-
Notifications
You must be signed in to change notification settings - Fork 471
Per-platform binary packages #7395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b659400 to
8f1f91c
Compare
|
@zth I would assume this will require some LSP server changes as well? |
fa8b385 to
de281cf
Compare
| path: | | ||
| rescript-${{ env.rescript_version }}.tgz | ||
| rescript-std-${{ env.rescript_version }}.tgz | ||
| rescript-linux-x64-${{ env.rescript_version }}.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use GitHub's package registry for nightly builds
a6f2e53 to
9ac523d
Compare
Each platform package will expose binary locations, making it easier to handle. import { binDir, binPaths } from "@rescript/linux-x64" |
8fe0b40 to
59c41fc
Compare
34223f4 to
e7c1064
Compare
Co-authored-by: Christoph Knittel <christoph@knittel.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! 🎉
|
Updated branch protections |
Resolves #6133 , Partially #6183
Use symbolic links in dev and replace them with real binaries during the packaging process.