Migrate Rewatch to Rust 2024 edition #7602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
commented
Jul 4, 2025
| break; | ||
| } else if !line.is_empty() { | ||
| deps.insert(line); | ||
| match helpers::read_lines(&ast_file) { |
There was a problem hiding this comment.
cargo fix made this change due to how drop order changed in Rust 2024.
See https://doc.rust-lang.org/nightly/edition-guide/rust-2024/temporary-tail-expr-scope.html#details
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
cknitt
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Rust 1.85.0, the Rust 2024 edition has been stabilised.
The changelog for that edition can be found here: https://blog.rust-lang.org/2025/02/20/Rust-1.85.0/#rust-2024
I followed the official Rust guide on migrating to a new edition, which gives the following steps:
cargo updateto update your dependencies to the latest versions (commit 77dcfab)cargo fix --edition(commit e299009)Cargo.tomland set theeditionfield to the next edition (commit e299009)cargo buildandcargo testcargo fmt(commit a423aad)