Suggest using JSX fragment where appropriate #7714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
cknitt
reviewed
Jul 25, 2025
|
|
||
| - Did you forget to wrap this + adjacent JSX in a JSX fragment ([1;33m<></>[0m)? | ||
| - Did you mean to assign this to a variable? | ||
| - If you don't care about the result of this expression, you can assign it to [1;33m_[0m via [1;33mlet _ = ...[0m or pipe it to [1;33mignore[0m via [1;33mexpression->ignore[0m |
There was a problem hiding this comment.
If the user wrote some JSX, he probably does not want to ignore it?
There was a problem hiding this comment.
Yeah that's a good point, we can omit that part for JSX.
zth
force-pushed
the
suggest-using-jsx-fragment-when-appropriate
branch
from
922175d to
49baf5f
Compare
cknitt
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies some sort of heuristic to guess when the user might've accidentally forgot to use JSX fragments.
It's not perfect, but I think it's an OK improvement.