Fix generation of interfaces for module types containing multiple type constraints #7825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an interface file with
rescript-editor-analysis createInterface SomeFile.res, invalid syntax was being generated for module types containing multiple type constraints.For example:
was being converted to interface:
but
with type identity = 'a with type t = 'bis invalid syntax and should have beenwith type identity = 'a and type t = 'b(notice the secondwithbecomesand).res_outcome_printerdid have existing logic to emitandinstead ofwith, but it relied on a ref counter that was not being incremented.