Skip to content

Global docstrings #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 22, 2025
Merged

Global docstrings #7976

merged 6 commits into from
Oct 22, 2025

Conversation

@fhammerschmidt
Copy link
Member

@fhammerschmidt fhammerschmidt commented Oct 22, 2025 •
edited
Loading

Part of #7546

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 22, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7976

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7976

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7976

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7976

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7976

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7976

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7976

commit: c06f5cf

tsnobip
tsnobip approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fhammerschmidt !

@tsnobip
Copy link
Member

tsnobip commented Oct 22, 2025

What's the policy here, should we add an entry to the changelog for this?

@fhammerschmidt
Copy link
Member Author

What's the policy here, should we add an entry to the changelog for this?

Still nah, I think.

#7556 (comment)

@fhammerschmidt fhammerschmidt merged commit f7e3343 into master Oct 22, 2025
25 checks passed
@fhammerschmidt fhammerschmidt deleted the global-docstrings branch October 22, 2025 14:38
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 22, 2025
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsnobip tsnobip tsnobip approved these changes

@cknitt cknitt Awaiting requested review from cknitt

@zth zth Awaiting requested review from zth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fhammerschmidt @tsnobip