-
Notifications
You must be signed in to change notification settings - Fork 17
legacy
subcommand & CLI structure refactor
#162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
--legacy
flag to proxy to legacy build system--legacy
flag to passthrough to legacy build system
e0084c2
to
b4945ea
Compare
5d7834f
to
6c3607f
Compare
6c3607f
to
bf41fd4
Compare
--legacy
flag to passthrough to legacy build systemlegacy
subcommand to passthrough to legacy build system
legacy
subcommand to passthrough to legacy build systemlegacy
subcommand & CLI structure refactor
@jfrolich It seems to be running a bit slower now, but I don't understand why it would be. |
Only in this PR? Or is the performance hit potentially introduced earlier? |
I noticed it because the snapshots are different. I think it is only this PR. |
if args are passed before a subcommand they conflict. args should be passed after the subcommand. `rewatch --no-timing build` will treat `build` as folder arg.
@jfrolich I had a misunderstanding and The confusion stemmed from |
This PR refactors the CLI structure of rewatch to enhance clarity and improve the usability of subcommands and their associated arguments.
Key Changes:
Introduction of New Subcommands:
legacy
: Acts as a passthrough to the legacy CLIrescript
. In the future, this will be namedrescript-legacy
.dump
: Serves as an alias forlegacy dump
.format
: Serves as an alias forlegacy format
.Breaking Change:
The
--compiler-args
argument has been replaced with a new subcommandcompiler-args
. I assume this change will have minimal impact. I guess this is mainly used as a debug command.Benefits:
The refactored structure ensures a more intuitive CLI experience by clearly delineating which arguments apply to specific subcommands.
The introduction of aliases (dump and format) simplifies common operations and aims to make the transition to rewatch as the default build system easier.
The new compiler-args subcommand makes the CLI behavior more consistent and predictable.