This repository was archived by the owner on Jun 15, 2023. It is now read-only.
  
  
  - 
                Notifications
    You must be signed in to change notification settings 
- Fork 38
Pipe reformat eats annotation #629
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            5 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      d7597c4
              
                Add example of pipe reformat eating annotation
              
              
                cristianoc 1d000e2
              
                Turns out `|>` has the same problem.
              
              
                cristianoc 3fec13e
              
                Fir reformatting issue for `->` and `|>`.
              
              
                cristianoc 6e87459
              
                Tweak test to show the difference between -> or |> and ** in printing.
              
              
                cristianoc e27f1be
              
                Check if there are printable attributes in pipe.
              
              
                cristianoc File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| let s1 = @ann (x->foo) | ||
| let s1b = (@ann x)->foo | ||
|  | ||
| let s2 = @ann (x |> foo) | ||
| let s2b = (@ann x) |> foo | ||
|  | ||
| let s3 = @ann (x ** foo) | ||
| let s3b = (@ann x) ** foo | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| let s1 = @ann (x->foo) | ||
| let s1b = @ann x->foo | ||
|  | ||
| let s2 = @ann (x|>foo) | ||
| let s2b = @ann x|>foo | ||
|  | ||
| let s3 = @ann (x**foo) | ||
| let s3b = @ann x**foo | 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seen this one before perhaps?
https://github.com/rescript-lang/syntax/pull/621/files#diff-5f509cef22744d6c22d0c7a7fc37bcb68a1bda23db28caa9dc2b20cdbfebb695R3661