Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Remove Caml_option.some from jsx mode #669

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Remove Caml_option.some from jsx mode #669

merged 2 commits into from
Oct 4, 2022

Conversation

@mununki
Copy link
Member

@mununki mununki commented Oct 4, 2022

This PR fixes #667

@mununki
Copy link
Member Author

mununki commented Oct 4, 2022

ReactDOM.someElement does not need In case of multiple children with React.array([child, child]). Caml_option.some is not used in generated output.

@mununki mununki changed the title Remove Caml_option.som from jsx mode Remove Caml_option.some from jsx mode Oct 4, 2022
@mununki mununki merged commit 5a54a86 into master Oct 4, 2022
@mununki mununki deleted the optimization-jsx-mode branch October 4, 2022 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cristianoc cristianoc cristianoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Jsx4 automatic mode: suspicious Caml_option.some

3 participants

@mununki @cristianoc