Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReScript 12 compatibility #78

Open
cknitt opened this issue Apr 7, 2025 · 0 comments · May be fixed by #79
Open

ReScript 12 compatibility #78

cknitt opened this issue Apr 7, 2025 · 0 comments · May be fixed by #79

Comments

@cknitt
Copy link
Member

cknitt commented Apr 7, 2025

When compiled with ReScript 12, the current Interop for the navigator modules as implemented in

export function adaptNavigatorModule(m) {
crashes at runtime with

TypeError: Cannot read property 'make' of undefined

This is because it relies on undocumented internals of ReScript 11, specifically that Navigator and Screen are treated as reserved words and therefore prefixed with$$ in the JS output (but Group isn't).

In ReScript 12, this behavior changed with rescript-lang/rescript#6831, and Navigator and Screen are no longer prefixed.

@cknitt cknitt linked a pull request Apr 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant