Missing options props#35
Conversation
MoOx
left a comment
There was a problem hiding this comment.
Awesome! Are you confident with this improvements (= should we cut another release?)
Also could you specify the version of react-navigation you refered to somewhere?
Maybe update this https://github.com/reason-react-native/reason-react-navigation/blob/master/package.json#L5 & add other packages so we people know better the version?
|
I tried those changes on my own project this week-end, it work well :)
For the |
|
I didn't tried all the new props/options, but I'm pretty confident about the ones I removed from |
|
For the peer deps yes, please do what is recommended, so only what user should have as deps :) And all of them. Worst case scenario is that you get a warning for a dep you don't use, that's acceptable for now As soon as you do that, I will adjust the version according to this... Since we don't "match" a single dep, the version number will be different that what we do for other packages. |
|
Updated peerDependencies to this: Regarding all packages changelog, it almost bugfixes, and features are almost typescript definitions and listeners things. There is a somes features linked to a specific minor version of a packaged but we don't supported them yet. So I think it's better to keep the 5.0.0 for the minimum version. |
|
Your PR is still in Draft, do you have other things to push or is it ready as it is? |
|
Nothing else to push for now ^^ |
|
Thank you! |
Add and removing props and options regarding react-navigation v5 documentation.