Skip to content

Add react ref and key props to components #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoOx merged 2 commits into from
Aug 20, 2020
Merged

Add react ref and key props to components #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00d45ff
add ref props to navigation container
Freddy03h Aug 17, 2020
f62f0a0
add key props for components
Freddy03h Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/BottomTabs.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ module Make = (M: {type params;}) => {
"navigation": navigation,
"route": route,
}),
~key: string=?,
unit
) =>
screenProps(M.params);
Expand All @@ -199,6 +200,7 @@ module Make = (M: {type params;}) => {
~options: optionsCallback=?,
~initialParams: M.params=?,
~children: renderCallbackProp => React.element,
~key: string=?,
unit
) =>
screenProps(M.params);
Expand All @@ -222,6 +224,7 @@ module Make = (M: {type params;}) => {
~_lazy: bool=?,
~tabBar: Js.t(bottomTabBarProps) => React.element=?,
~tabBarOptions: bottomTabBarOptions=?,
~key: string=?,
unit
) =>
navigatorProps;
Expand Down
2 changes: 2 additions & 0 deletions src/Drawer.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ module Make = (M: {type params;}) => {
"navigation": navigation,
"route": route(M.params),
}),
~key: string=?,
unit
) =>
screenProps;
Expand Down Expand Up @@ -162,6 +163,7 @@ module Make = (M: {type params;}) => {
~drawerContentOptions: Js.t(contentOptions)=?,
~sceneContainerStyle: ReactNative.Style.t=?,
~style: ReactNative.Style.t=?,
~key: string=?,
unit
) =>
navigatorProps;
Expand Down
3 changes: 3 additions & 0 deletions src/MaterialBottomTabs.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ module Make = (M: {type params;}) => {
~options: optionsCallback=?,
~initialParams: M.params=?,
~component: React.component({. "navigation": navigation}),
~key: string=?,
unit
) =>
screenProps(M.params);
Expand All @@ -138,6 +139,7 @@ module Make = (M: {type params;}) => {
~options: optionsCallback=?,
~initialParams: M.params=?,
~children: renderCallbackProp => React.element,
~key: string=?,
unit
) =>
screenProps(M.params);
Expand All @@ -164,6 +166,7 @@ module Make = (M: {type params;}) => {
~inactiveColor: string=?,
~barStyle: ReactNative.Style.t=?,
//TODO: More? https://github.com/callstack/react-native-paper/blob/bd4296116d841ed355f3dbebb40cfbc3b87a79ff/src/components/BottomNavigation.tsx#L132-L196
~key: string=?,
unit
) =>
navigatorProps;
Expand Down
3 changes: 3 additions & 0 deletions src/MaterialTopTabs.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ module Make = (M: {type params;}) => {
~options: optionsCallback=?,
~initialParams: M.params=?,
~component: React.component({. "navigation": navigation}),
~key: string=?,
unit
) =>
screenProps(M.params);
Expand All @@ -193,6 +194,7 @@ module Make = (M: {type params;}) => {
~options: optionsCallback=?,
~initialParams: M.params=?,
~children: renderCallbackProp => React.element,
~key: string=?,
unit
) =>
screenProps(M.params);
Expand Down Expand Up @@ -230,6 +232,7 @@ module Make = (M: {type params;}) => {
~swipeVelocityImpact: float=?,
~sceneContainerStyle: ReactNative.Style.t=?,
~style: ReactNative.Style.t=?,
~key: string=?,
unit
) =>
navigatorProps;
Expand Down
1 change: 1 addition & 0 deletions src/Native.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ module NavigationContainer = {
[@bs.module "@react-navigation/native"] [@react.component]
external make:
(
~ref: ReactNative.NativeElement.ref=?,
Copy link
Member

@MoOx MoOx Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems unecessary

Copy link
Member Author

@Freddy03h Freddy03h Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work without it, and I looked on other project to do it : https://github.com/reason-react-native/datetimepicker/blob/f479766c79ce24248c8752c2b1a6e5edb35bb2b1/src/ReactNativeDateTimePicker.re#L21

~initialState: state=?,
~onStateChange: navigationState=?,
~children: React.element
Expand Down
3 changes: 3 additions & 0 deletions src/Stack.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ module Make = (M: {type params;}) => {
~options: optionsCallback=?,
~initialParams: M.params=?,
~children: renderCallbackProp => React.element,
~key: string=?,
unit
) =>
screenProps(M.params);
Expand All @@ -323,6 +324,7 @@ module Make = (M: {type params;}) => {
"navigation": navigation,
"route": route,
}),
~key: string=?,
unit
) =>
screenProps(M.params);
Expand All @@ -340,6 +342,7 @@ module Make = (M: {type params;}) => {
~headerMode: [@bs.string] [ | `float | `screen | `none]=?,
~keyboardHandlingEnabled: bool=?,
~children: React.element,
~key: string=?,
unit
) =>
navigatorProps;
Expand Down