Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 9.0: The StartParameter.settingsFile property has been deprecated. #379

Open
IRus opened this issue Apr 19, 2023 · 16 comments
Open

Comments

@IRus
Copy link
Contributor

IRus commented Apr 19, 2023

The StartParameter.settingsFile property has been deprecated.
This is scheduled to be removed in Gradle 9.0.
Please use 'projectDir' to specify the directory of the default project instead.
Documentation
1 usage
Plugin:net.researchgate.release

at org.gradle.StartParameter.logBuildOrSettingsFileDeprecation(StartParameter.java:504)	
	•••
at net.researchgate.release.ReleasePlugin$_apply_closure5.doCall(ReleasePlugin.groovy:107)	
	•••
at net.researchgate.release.ReleasePlugin.apply(ReleasePlugin.groovy:100)	
at net.researchgate.release.ReleasePlugin.apply(ReleasePlugin.groovy)	
	•••
@Vampire
Copy link
Contributor

Vampire commented Jul 4, 2023

Would probably also be fixed by fixing #304

@patton73
Copy link

patton73 commented Feb 6, 2024

Any news in fixing this? Thanks.

@andersb
Copy link

andersb commented Feb 20, 2024

Just updated to Gradle 8.x and got the same warning. It still works for now but at some point this might hold back updating Gradle. Great plugin otherwise 👍

@pgehl
Copy link

pgehl commented Mar 16, 2024

Gradle 9.0 is coming fast. And no code commit listed in the last 2 years. Is this project still alive ?

@patton73
Copy link

Honestly i cannot understand why people start projects and the suddenly abandon them. I hope this project is not dead. But no commits in 2 years is a really bad signal.

@windmueller
Copy link

Honestly i cannot understand why people start projects and the suddenly abandon them.

You can't seriously imagine that personal circumstances could change in such a way that one can no longer find the time for a project that one would like to take?

But perhaps the author no longer uses Gradle so there could be a huge drop regarding motivation.

However, this is all speculation and has nothing to do with the problem at hand. Perhaps it is time for an "official" fork.

@pgehl
Copy link

pgehl commented Mar 17, 2024

My apologies to the author . My question was not ment in an offensive way.
I'm honestly grateful for this plugin and all the years I used it free of charge.
I asked only if the project was still alive to be able to plan a transition for the tens of projects that use it.
Again, thanks the author(s) for all those years.

@patton73
Copy link

You can't seriously imagine that personal circumstances could change in such a way that one can no longer find the time for a project that one would like to take?

Well sure i can imagine because real life could always be very complicated. But when this happens then you can always try to find someone else who can continue the work. The community is usually big and people are awesome in helping.
Asking for help does not cost too much.

@patton73
Copy link

I asked only if the project was still alive to be able to plan a transition for the tens of projects that use it.

Ehm excuse me. Plan a transition to what exactly? Is there a similar plugin?
Thanks for any information you can provide.

@pgehl
Copy link

pgehl commented Mar 18, 2024

Is there a similar plugin?

I don't know, answering that question will be one of the early parts of the transition plan.

@Doc94
Copy link

Doc94 commented May 12, 2024

maybe im confuse but this cannot help or is totally different task?
https://docs.gradle.org/current/userguide/publishing_maven.html

@Vampire
Copy link
Contributor

Vampire commented May 12, 2024

Totally different, yes. :-)

@IRus
Copy link
Contributor Author

IRus commented May 13, 2024

If the fix for this particular issue is just removing one line?

https://github.com/researchgate/gradle-release/blob/main/src/main/groovy/net/researchgate/release/ReleasePlugin.groovy#L107

Or this change would break some older Gradle versions?

@patton73
Copy link

patton73 commented May 13, 2024

Dunno really if it will break older version but basically a new plugin version can be compatible with latest gradle's versions. and not every one. At least it should be. And are we sure that the plugins itself does not uses that property inside instead of projectDir property?

@Vampire
Copy link
Contributor

Vampire commented May 13, 2024

If the fix for this particular issue is just removing one line?

There are other problems, and as I said above, the best would be to solve #304 which would also fix this one alongside.

@IRus
Copy link
Contributor Author

IRus commented May 13, 2024

@Vampire yes, I agree, but it appears that this is a minor fix that can be done before #304

@Hillkorn any chance giving commit rights to @Vampire? I can help with testing. Gradle seems not pushing 9.0 soon, there is 8.8-8.10 in queue, but composite builds requested by the community, and we could work on fixing this, as well as merging PR queue.

Hillkorn pushed a commit that referenced this issue Jul 8, 2024
* Remove deprecated property use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants