Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown in email - value.includes in escapeQuotes #1632

Closed
MartinN3 opened this issue Aug 27, 2024 · 3 comments · Fixed by #1801
Closed

Markdown in email - value.includes in escapeQuotes #1632

MartinN3 opened this issue Aug 27, 2024 · 3 comments · Fixed by #1801

Comments

@MartinN3
Copy link

MartinN3 commented Aug 27, 2024

Describe the Bug

When using markdownCustomStyles, parseCssInJsToInlineCss calls escapeQuotes on fontWeight: 500, in h1 tag and that fails but when using fontWeight: '500' it goes trough.

Which package is affected (leave empty if unsure)

react-email

Link to the code that reproduces this issue

is there a default repo we can clone and tailor?

To Reproduce

<Markdown
        children={`# Welcome to`}
        markdownCustomStyles={{
          h1: {
            fontSize: 70,
            fontWeight: 500,
          },
        }}
      />
"dependencies": {
        "@react-email/components": "0.0.23",
        "@react-email/render": "^1.0.0",
        "express": "4.19.2",
        "react": "18.3.1",
        "react-dom": "18.3.1",
        "react-email": "^3.0.1",
        "typescript": "^5.5.4"
 },

Expected Behavior

I think you would wanna override h1 fontWeight and you would do it easily by specifying fontWeight: 500, right?

What's your node version? (if relevant)

No response

@MartinN3 MartinN3 added the Type: Bug Confirmed bug label Aug 27, 2024
@VedantPatel04
Copy link

I'm working on this!

@Hainesy
Copy link

Hainesy commented Oct 30, 2024

Any update on this? Thanks

@gabrielmfern
Copy link
Collaborator

Just released @react-email/markdown@0.0.13-canary.1/@react-email/components@0.0.29-canary.2 that fixes this issue. Once we merge the fix into stable, I'll close out this issue.

@gabrielmfern gabrielmfern linked a pull request Dec 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants