chore: Add direct support for React 19 #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielmfern
force-pushed
the
chore/use-react-beta
branch
from
4485387 to
f1be85e
Compare
gabrielmfern
force-pushed
the
chore/use-react-beta
branch
from
f1be85e to
3489eb2
Compare
gabrielmfern
changed the title
gabrielmfern
force-pushed
the
chore/use-react-beta
branch
from
ffe2c22 to
c6f3116
Compare
gabrielmfern
force-pushed
the
chore/use-react-beta
branch
from
9aeb41c to
95835e2
Compare
This reverts commit 801ee64.
gabrielmfern
force-pushed
the
chore/use-react-beta
branch
from
8c740f6 to
f11b066
Compare
gabrielmfern
added a commit
that referenced
this pull request
Jul 24, 2024
gabrielmfern
added a commit
that referenced
this pull request
Aug 5, 2024
gabrielmfern
added a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all of our
reactandreact-dompeer dependencies so that they support both all18.0.0and19.0.0, specifically it changes them to^18.0 || ^19.0. It also updates the React on thedemoto be React 19 making sure that everything works there. I have also tested usingyalcto make sure that it still works with React 18, and it does just fine.One trade I had to make was that Next was proving to cause issues if it was on canary while running for a project that used React 19. The easiest solution for now was to use React 18 with Next 14 for now. This has a trade-off of the
email exporttest failing because of different React versions across the workspace. The best fix for this can only come out of this POC branch.