Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(docs): add await to the integration examples in the documentation #1672

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ickynavigator
Copy link
Contributor

Changed the docs integration examples to use the await since render now returns a Promise<string> and not a string. There are still some more changes that need to be made in the examples/[INTEGRATION] folder but for some reason my pnpm and the one on codespaces is unable to complete the pnpm install command

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: d521e6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 10, 2024

@ickynavigator is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@gabrielmfern gabrielmfern changed the base branch from canary to main September 11, 2024 14:38
@gabrielmfern
Copy link
Collaborator

Thanks for this! Will fix the missing await on the examples

@ickynavigator
Copy link
Contributor Author

you're welcome!!

btw this is the error i got when i tried to install and work on the examples

~/ghq/github.com/resend/react-email
❯ ni
Scope: all 31 workspace projects
Lockfile is up to date, resolution step is skipped
Already up to date
 WARN  Failed to create bin at /Users/fortuneobi/ghq/github.com/resend/react-email/apps/demo/node_modules/.bin/email. ENOENT: no such file or directory, open '/Users/fortuneobi/ghq/github.com/resend/react-email/packages/react-email/dist/cli/index.js'
 WARN  Failed to create bin at /Users/fortuneobi/ghq/github.com/resend/react-email/apps/web/node_modules/.bin/email. ENOENT: no such file or directory, open '/Users/fortuneobi/ghq/github.com/resend/react-email/packages/react-email/dist/cli/index.js'
 WARN  Failed to create bin at /Users/fortuneobi/ghq/github.com/resend/react-email/benchmarks/preview-server/node_modules/.bin/email. ENOENT: no such file or directory, open '/Users/fortuneobi/ghq/github.com/resend/react-email/packages/react-email/dist/cli/index.js'
 WARN  Failed to create bin at /Users/fortuneobi/ghq/github.com/resend/react-email/packages/create-email/template/node_modules/.bin/email. ENOENT: no such file or directory, open '/Users/fortuneobi/ghq/github.com/resend/react-email/packages/react-email/dist/cli/index.js'
 WARN  Failed to create bin at /Users/fortuneobi/ghq/github.com/resend/react-email/benchmarks/preview-server/node_modules/.bin/email. ENOENT: no such file or directory, open '/Users/fortuneobi/ghq/github.com/resend/react-email/benchmarks/preview-server/node_modules/react-email/dist/cli/index.js'
 WARN  3 other warnings
Done in 1.5s

@gabrielmfern gabrielmfern merged commit 598fe95 into resend:main Sep 11, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants