-
Notifications
You must be signed in to change notification settings - Fork 874
chore(deps): upgrade prettier to 3.5.3 #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@h4sohail is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
|
The CI failures look unrelated 🤔 |
|
This issue will resurface as soon as a new |
ee02f3d to
2e0727b
Compare
|
I like the idea of allowing minor upgrades but since all of the other packages are using pinned versions I opt'ed to use a pinned version here as well. I will leave it up-to the react-email team to decide. |
gabrielmfern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We pin all versions, we'd rather have it pinned for non-peer dependencies. |
|
May be prettier can be made optional? Not sure about the Just thinking out loud, May be it can be its own package instead of being an option. something like |
Could just move the package in package.json to |
|
From the package perspective,
|
|
Waiting for this to go live! |
|
BTW prettier should be a peer dep in this repo, not a regular dependency |
Resolves #1910