Skip to content

Conversation

@h4sohail
Copy link
Contributor

@h4sohail h4sohail commented Mar 15, 2025

Resolves #1910

@vercel
Copy link

vercel bot commented Mar 15, 2025

@h4sohail is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@h4sohail h4sohail changed the title Upgrade prettier to 3.5.3 chore(deps): upgrade prettier to 3.5.3 Mar 15, 2025
@h4sohail h4sohail marked this pull request as ready for review March 15, 2025 22:41
@h4sohail
Copy link
Contributor Author

The CI failures look unrelated 🤔

@j0nas
Copy link

j0nas commented Mar 17, 2025

This issue will resurface as soon as a new prettier patch version is released. Should we specify "prettier": "^3.5.3",?

@h4sohail h4sohail force-pushed the hs/upgrade-prettier branch from ee02f3d to 2e0727b Compare March 18, 2025 04:25
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 2e0727b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@h4sohail
Copy link
Contributor Author

This issue will resurface as soon as a new prettier patch version is released. Should we specify "prettier": "^3.5.3",?

I like the idea of allowing minor upgrades but since all of the other packages are using pinned versions I opt'ed to use a pinned version here as well. I will leave it up-to the react-email team to decide.

Copy link
Member

@gabrielmfern gabrielmfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gabrielmfern
Copy link
Member

I like the idea of allowing minor upgrades but since all of the other packages are using pinned versions I opt'ed to use a pinned version here as well. I will leave it up-to the react-email team to decide.

We pin all versions, we'd rather have it pinned for non-peer dependencies.

@gabrielmfern gabrielmfern merged commit 7fc787f into resend:canary Mar 20, 2025
4 of 7 checks passed
@opswiz
Copy link

opswiz commented Mar 21, 2025

May be prettier can be made optional? Not sure about the how to's yet,

Just thinking out loud, May be it can be its own package instead of being an option. something like @react-email/pretty, so we can use if if necessary. I am not sure about others on how commonly this option is required. I never see it as a required option for my cases for sending emails

@h4sohail
Copy link
Contributor Author

May be prettier can be made optional? Not sure about the how to's yet,

Just thinking out loud, May be it can be its own package instead of being an option. something like @react-email/pretty, so we can use if if necessary. I am not sure about others on how commonly this option is required. I never see it as a required option for my cases for sending emails

Could just move the package in package.json to devDependencies

@opswiz
Copy link

opswiz commented Mar 21, 2025

From the package perspective, options.pretty is a direct usage. having it in devDependency will break if the user don't use/have prettier installed or environments like production where devDependencies might not be installed.

peerDependencies with unpinned can work, now a days package managers treats peerDependencies too like dependencies I think, npm does, not sure about others.

@elie222
Copy link

elie222 commented Mar 22, 2025

Waiting for this to go live!

@capaj
Copy link

capaj commented Apr 15, 2025

BTW prettier should be a peer dep in this repo, not a regular dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prettier warning in console

6 participants