Skip to content

fix(render): reactDOMServer import on browser and some bundlers #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabrielmfern merged 3 commits into from
May 7, 2025
Merged

fix(render): reactDOMServer import on browser and some bundlers #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5926dc
fix(render): reactDOMServer import on browser and some bundlers
MendyLanda May 6, 2025
2622dbc
add comment
gabrielmfern May 7, 2025
039ea43
add changeset
gabrielmfern May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/free-sides-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-email/render": patch
---

fix react-dom/server import for the browser and some bundlers
5 changes: 4 additions & 1 deletion packages/render/src/browser/render.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ export const render = async (
options?: Options,
) => {
const suspendedElement = <Suspense>{element}</Suspense>;
const reactDOMServer = await import('react-dom/server');
const reactDOMServer = await import('react-dom/server').then(
// This is beacuse react-dom/server is CJS
(m) => m.default,
);

let html!: string;
if (Object.hasOwn(reactDOMServer, 'renderToReadableStream')) {
Expand Down
5 changes: 4 additions & 1 deletion packages/render/src/node/render.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ export const render = async (
options?: Options,
) => {
const suspendedElement = <Suspense>{element}</Suspense>;
const reactDOMServer = await import('react-dom/server');
const reactDOMServer = await import('react-dom/server').then(
// This is beacuse react-dom/server is CJS
(m) => m.default,
);

let html!: string;
if (Object.hasOwn(reactDOMServer, 'renderToReadableStream')) {
Expand Down
Loading