Skip to content

fix(react-email): security issue with path for static files #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabrielmfern merged 2 commits into from
Jun 10, 2025
Merged

fix(react-email): security issue with path for static files #2289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcd0a3b
fix use of externally controlled format string
gabrielmfern Jun 10, 2025
2660744
add changeset
gabrielmfern Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-showers-exist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-email": patch
---

fix static file serving security issue with logging
3 changes: 2 additions & 1 deletion packages/react-email/src/utils/preview/serve-static-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ export const serveStaticFile = async (
} else {
const sanitizedFilePath = fileAbsolutePath.replace(/\n|\r/g, '');
console.error(
`Could not read file at ${sanitizedFilePath} to be served, here's the exception:`,
`Could not read file at %s to be served, here's the exception:`,
sanitizedFilePath,
exception,
);

Expand Down
Loading