fix: Remove optionality from required types #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukinoshita
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a longstanding issue with inconsistencies around types for the
reactprop specificallyby using the
RequireAtLeastOnegeneric we are already telling TS that all props are optional, but at least one is required. but having the?mark in thereactprop we confuse the compiler sinceundefinedis not a valid React Node element and it breaks.so for a while now we have users sometimes having to cast
React.ReactNodetypes toReact.ReactElementand some other workarounds.this should no longer be needed and we now have type consistency 🙏