Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use dynamic import for @react-email/render #438

Merged
merged 2 commits into from
Nov 18, 2024
Merged

feat: Use dynamic import for @react-email/render #438

merged 2 commits into from
Nov 18, 2024

Conversation

vcapretz
Copy link
Member

@vcapretz vcapretz commented Oct 22, 2024 •
edited
Loading

use dynamic import for @react-email/render only when the react prop is used

@vcapretz vcapretz self-assigned this Oct 22, 2024
@vcapretz vcapretz requested a review from a team as a code owner October 22, 2024 16:44
gabrielmfern
gabrielmfern reviewed Oct 22, 2024
View reviewed changes
src/batch/batch.ts Outdated Show resolved Hide resolved
gabrielmfern
gabrielmfern approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@gabrielmfern gabrielmfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@bukinoshita
Copy link
Member

@vcapretz Can you release an alpha version of it?

@socket-security Socket Security
Copy link

socket-security bot commented Oct 29, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@react-email/render@1.0.1 Transitive: environment, filesystem, network, shell +65 11.5 MB gabrielmfern

🚮 Removed packages: npm/@react-email/render@0.0.17

View full report↗︎

@vcapretz
Copy link
Member Author

@bukinoshita resend@4.0.1-alpha.0 is now available to test

@vcapretz vcapretz changed the title feat: Remove @react-email/render from required dependencies list feat: Use dynamic import for @react-email/render Oct 29, 2024
@bukinoshita bukinoshita merged commit 83bbeca into canary Nov 18, 2024
8 checks passed
@bukinoshita bukinoshita deleted the remove-react-email-dep branch November 18, 2024 16:37
bukinoshita pushed a commit that referenced this pull request Nov 18, 2024
@vcapretz @bukinoshita
feat: Use dynamic import for @react-email/render (#438)
cfad2ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmfern gabrielmfern gabrielmfern approved these changes

@bukinoshita bukinoshita bukinoshita approved these changes

Assignees

@vcapretz vcapretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vcapretz @bukinoshita @gabrielmfern