Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access-Control-Allow-Credentials header #181

Closed
jirenius opened this issue Feb 3, 2021 · 1 comment
Closed

Access-Control-Allow-Credentials header #181

jirenius opened this issue Feb 3, 2021 · 1 comment
Assignees
@jirenius
Labels
bug Something isn't working

Comments

@jirenius
Copy link
Collaborator

jirenius commented Feb 3, 2021

Issue

When a browser makes a CORS requests with credentials set to include, Resgate should include in the response the header:

Access-Control-Allow-Credentials: true

If the header is not included, the browsers will not expose the response to frontend JavaScript code.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Credentials

Notes

  • The header should only be included if Resgate is configured with headerAuth.
@jirenius jirenius added the bug Something isn't working label Feb 3, 2021
@jirenius jirenius self-assigned this Feb 3, 2021
jirenius added a commit that referenced this issue Feb 3, 2021
@jirenius
GH-181: Added Access-Control-Allow-Credentials header in response to …
f27b6bb 
…HTTP requests
jirenius added a commit that referenced this issue Feb 3, 2021
@jirenius
GH-181: Added tests for headerAuth and Access-Control-Allow-Credentia…
08366df 
…ls header
jirenius added a commit that referenced this issue Feb 3, 2021
@jirenius
Merge pull request #182 from resgateio/bugfix/gh-181-access-control-a…
7cd3202 
…llow-credentials-header

Bugfix/gh 181 access control allow credentials header
@jirenius
Copy link
Collaborator Author

jirenius commented Feb 3, 2021

Resolved in #182

@jirenius jirenius closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jirenius jirenius

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jirenius