Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smarteole_example.ipynb ops curves by toggle plot is wrong #32

Closed
aclerc opened this issue Sep 26, 2024 · 0 comments · Fixed by #34
Closed

smarteole_example.ipynb ops curves by toggle plot is wrong #32

aclerc opened this issue Sep 26, 2024 · 0 comments · Fixed by #34
Assignees
@samuelwnaylor
Labels
bug Something isn't working

Comments

@aclerc
Copy link
Contributor

aclerc commented Sep 26, 2024 •
edited
Loading

A slight problem has been introduced to this plot in smarteole_example.ipynb, the toggle on data is apparently plotted twice
image

The plot looks OK before PR#29
https://github.com/resgroup/wind-up/blob/5fee858de3683d159c996b5570f575a12215b61e/examples/smarteole_example.ipynb

@samuelwnaylor sorry I missed this in the PR review
@aclerc aclerc added the bug Something isn't working label Sep 26, 2024
@aclerc aclerc changed the title ops curves by toggle plot is wrong smarteole_example.ipynb ops curves by toggle plot is wrong Sep 26, 2024
samuelwnaylor added a commit that referenced this issue Sep 26, 2024
@samuelwnaylor
fix: remove duplicate plot trace
3612cb4 
Fixes #32
@samuelwnaylor samuelwnaylor mentioned this issue Sep 26, 2024
Merged
aclerc pushed a commit that referenced this issue Sep 26, 2024
@samuelwnaylor
fix: remove duplicate plot trace (#34)
b58aa58 
Fixes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuelwnaylor samuelwnaylor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove duplicate plot trace resgroup/wind-up
2 participants
@aclerc @samuelwnaylor