Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore timestamp columns in stuck data function #39

Merged
merged 3 commits into from
Nov 4, 2024
Merged

fix: ignore timestamp columns in stuck data function #39

merged 3 commits into from
Nov 4, 2024

Conversation

samuelwnaylor
Copy link
Collaborator

Fixes #38

@samuelwnaylor samuelwnaylor requested a review from aclerc November 4, 2024 13:44
@samuelwnaylor samuelwnaylor changed the title fix: preserve dataframe dtypes fix: ignore timestamp columns in stuck data function Nov 4, 2024
aclerc
aclerc approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@aclerc aclerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! well done

@aclerc aclerc merged commit 7acc0f1 into main Nov 4, 2024
2 checks passed
@aclerc aclerc deleted the fix-diff branch November 4, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclerc aclerc aclerc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timestamp column can be converted to type "object" which potentially causes the .diff() to fail
2 participants
@samuelwnaylor @aclerc