This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
[WIP] feat: add generalized redirect AuthAction #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ? onRedirect.whenAuthed | ||
| : onRedirect.whenUnauthed | ||
|
|
||
| if (!authStateConfig || !authStateConfig.destination) { |
There was a problem hiding this comment.
Suggested change
| if (!authStateConfig || !authStateConfig.destination) { | |
| if (!authStateConfig?.destination) { |
Although that implies and - was the OR intentional before? Or were you intending to do:
if (authStateConfig && !authStateConfig.destination)So that it is defined, but missing the destination. Thats what the error message seemed to imply anyway
There was a problem hiding this comment.
Or maybe I'm misunderstanding since that seems to be what you do below?
|
|
||
| if (!authStateConfig || !authStateConfig.destination) { | ||
| throw new Error( | ||
| `The "destination" in the "onRedirect.whenAuthed" and "onRedirect.whenUnauthed" redirect configs must resolve to a non-empty string` |
There was a problem hiding this comment.
Nit: We could technically make this only call out the offender here instead of both (with a conditional like you did above)
| @@ -144,6 +145,39 @@ const withAuthUserTokenSSR = | |||
| } | |||
| } | |||
|
|
|||
| if ([whenAuthed, whenUnauthed].includes(AuthAction.REDIRECT)) { | |||
| const redirectConfig = onRedirect || getConfig().onRedirect | |||
There was a problem hiding this comment.
Nice - I like the overridable with local config with fallback to global
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.