Merge pull request #78 from reside-eng/PLAT-8525-update-slack-weebhooks

fix: cleanup unneeded secrets + update default slack channel
reside-eng · Oct 30, 2024 · 614edc8 · 614edc8
2 parents 1734b99 + 2a8e4f7
commit 614edc8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 29 deletions.
diff --git a/.github/workflows/release_library.yml b/.github/workflows/release_library.yml
@@ -36,20 +36,13 @@ on:
         required: false
         type: boolean
       SLACK_NOTIFICATION_SECRET:
-        default: 'SLACK_WEBHOOK_PLATFORM_PROD'
+        default: 'SLACK_WEBHOOK_PLATFORM_NONPROD'
         required: false
         type: string
 
     secrets:
       NPM_PUBLISH_TOKEN:
         required: true
-      #Note: Due to some github actions limitations all the slack webhook secrets that could be used by the librairies need to be added here with required: false
-      SLACK_WEBHOOK_CORE_NON_PROD:
-        required: false
-      SLACK_WEBHOOK_PLATFORM_PROD:
-        required: false
-      SLACK_WEBHOOK_PLATFORM_SERVICES_NONPROD:
-        required: false
       #Secret needed when ENABLE_VISUAL_TESTING = true:
       # - SIDE_CI_APPLICATION_ID
       # - SIDE_CI_APPLICATION_PRIVATE_KEY

diff --git a/.github/workflows/verify_library.yml b/.github/workflows/verify_library.yml
@@ -59,17 +59,6 @@ on:
     secrets:
       NPM_READ_TOKEN:
         required: true
-      # Note: Due to some github actions limitations all the slack webhook secrets that could be used by the libraries need to be added here with required: false
-      SLACK_WEBHOOK_CORE_NON_PROD:
-        required: false
-      SLACK_WEBHOOK_PLATFORM_PROD:
-        required: false
-      SLACK_WEBHOOK_PLATFORM_NONPROD:
-        required: false
-      SLACK_WEBHOOK_PLATFORM_SERVICES_NONPROD:
-        required: false
-      SLACK_WEBHOOK_UI_WG:
-        required: false
       # Secret needed when ENABLE_VISUAL_TESTING = true:
       # - CI_SERVICE_ACCOUNT
       # - PERCY_TOKEN

diff --git a/README.md b/README.md
@@ -20,17 +20,13 @@ Templates for Side librairies github actions
 | ENABLE_VISUAL_TESTING | boolean | false | `false` |
 | IS_MONOREPO | boolean | false | `false` |
 | ENABLE_SLACK_NOTIFICATION | boolean | true | `false` |
-| SLACK_NOTIFICATION_SECRET | string | SLACK_WEBHOOK_CORE_NON_PROD | `false` |
+| SLACK_NOTIFICATION_SECRET | string | SLACK_WEBHOOK_PLATFORM_NONPROD | `false` |
 
 ### Secrets
 
 | Secret | Required |
 | ---------------------- | ---------------------- |
 | NPM_READ_TOKEN | `true` |
-| SLACK_WEBHOOK_CORE_NON_PROD | `false` |
-| SLACK_WEBHOOK_PLATFORM_PROD | `false` |
-| SLACK_WEBHOOK_PLATFORM_SERVICES_NONPROD | `false` |
-| SLACK_WEBHOOK_UI_WG | `false` |
 | CI_SERVICE_ACCOUNT | `false` |
 
 
@@ -48,17 +44,13 @@ Templates for Side librairies github actions
 | ENABLE_VISUAL_TESTING | boolean | false | `false` |
 | IS_MONOREPO | boolean | false | `false` |
 | ENABLE_SLACK_NOTIFICATION | boolean | true | `false` |
-| SLACK_NOTIFICATION_SECRET | string | SLACK_WEBHOOK_CORE_NON_PROD | `false` |
+| SLACK_NOTIFICATION_SECRET | string | SLACK_WEBHOOK_PLATFORM_NONPROD | `false` |
 
 ### Secrets
 
 | Secret | Required |
 | ---------------------- | ---------------------- |
 | NPM_PUBLISH_TOKEN | `true` |
-| SLACK_WEBHOOK_CORE_NON_PROD | `false` |
-| SLACK_WEBHOOK_PLATFORM_PROD | `false` |
-| SLACK_WEBHOOK_PLATFORM_SERVICES_NONPROD | `false` |
-| SLACK_WEBHOOK_UI_WG | `false` |
 | CI_SERVICE_ACCOUNT | `false` |
 | SIDE_CI_APPLICATION_ID | `false` |
 | SIDE_CI_APPLICATION_PRIVATE_KEY | `false` |