Merge pull request #94 from reside-eng/PLAT-8743-remove-coveralls-upload

feat: remove coverall upload + upload summary to Cloud Storage
reside-eng · Dec 11, 2024 · 8e55e6d · 8e55e6d
2 parents f9454fc + bc05e3a
commit 8e55e6d
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 13 deletions.
diff --git a/.github/workflows/check-nodejs-dependencies.yml b/.github/workflows/check-nodejs-dependencies.yml
@@ -29,7 +29,7 @@ on:
         required: false
         type: string
     secrets:
-      DEPENDENCY_STATS_SERVICE_ACCOUNT:
+      LIBRARY_CI_SERVICE_ACCOUNT:
         required: true
       NPM_READ_TOKEN:
         required: true
@@ -87,7 +87,7 @@ jobs:
         uses: google-github-actions/auth@v2
         with:
           project_id: reside-stage
-          credentials_json: ${{ secrets.DEPENDENCY_STATS_SERVICE_ACCOUNT }}
+          credentials_json: ${{ secrets.LIBRARY_CI_SERVICE_ACCOUNT }}
 
       # setup-gcloud without components is required to have the proper authentication for gsutil commands
       - name: Set up Google Cloud CLI

diff --git a/.github/workflows/release_library.yml b/.github/workflows/release_library.yml
@@ -45,7 +45,7 @@ on:
         required: true
       NPM_READ_TOKEN:
         required: true
-      DEPENDENCY_STATS_SERVICE_ACCOUNT:
+      LIBRARY_CI_SERVICE_ACCOUNT:
         required: true
       #Secret needed when ENABLE_VISUAL_TESTING = true:
       # - SIDE_CI_APPLICATION_ID
@@ -67,6 +67,8 @@ jobs:
     name: release
     runs-on: ubuntu-latest
     timeout-minutes: ${{ inputs.TIMEOUT }}
+    env:
+      SERVICE_NAME: ${{ github.event.repository.name }}
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -102,11 +104,35 @@ jobs:
         if: inputs.ENABLE_TESTING && inputs.ENABLE_COVERAGE
         run: yarn test:cov
 
-      - name: Upload coverage to Coveralls
+      - name: Authenticate with Google Cloud
         if: inputs.ENABLE_TESTING && inputs.ENABLE_COVERAGE
-        uses: coverallsapp/github-action@v2.3.4
+        uses: google-github-actions/auth@v2
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
+          project_id: reside-stage
+          credentials_json: ${{ secrets.LIBRARY_CI_SERVICE_ACCOUNT }}
+
+      # setup-gcloud without components is required to have the proper authentication for gsutil commands
+      - name: Set up Google Cloud CLI
+        if: inputs.ENABLE_TESTING && inputs.ENABLE_COVERAGE
+        uses: google-github-actions/setup-gcloud@v2
+        with:
+          install_components: ''
+
+      - name: Upload coverage summary
+        if: inputs.ENABLE_TESTING && inputs.ENABLE_COVERAGE
+        run: |
+          coverage_summary="./coverage/coverage-summary.json"
+
+          if [ ! -f "$coverage_summary" ]; then
+              npx nyc report --reporter=json-summary -t coverage
+          fi
+          
+          bucket=reside-stage-plat-tools
+          summaryFolder=coverage-reporting/summary
+
+          gsutil -m -q cp $coverage_summary gs://$bucket/$summaryFolder/$SERVICE_NAME/$(date +%Y-%m-%d_%H-%M-%S).json
+          gsutil -m -q cp $coverage_summary gs://$bucket/$summaryFolder/$SERVICE_NAME/latest.json
+          echo "Coverage summary file uploaded successfully"
 
       - name: Build app
         if: inputs.ENABLE_BUILDING
@@ -200,7 +226,7 @@ jobs:
       NODE_VERSION: ${{ inputs.NODE_VERSION }}
     secrets:
       NPM_READ_TOKEN: ${{ secrets.NPM_READ_TOKEN }}
-      DEPENDENCY_STATS_SERVICE_ACCOUNT: ${{ secrets.DEPENDENCY_STATS_SERVICE_ACCOUNT }}
+      LIBRARY_CI_SERVICE_ACCOUNT: ${{ secrets.LIBRARY_CI_SERVICE_ACCOUNT }}
 
   notification:
     if: always() && inputs.ENABLE_SLACK_NOTIFICATION

diff --git a/.github/workflows/verify_library.yml b/.github/workflows/verify_library.yml
@@ -111,12 +111,6 @@ jobs:
         if: inputs.ENABLE_TESTING && inputs.ENABLE_COVERAGE
         run: yarn test:cov
 
-      - name: Upload coverage to Coveralls
-        if: inputs.ENABLE_TESTING && inputs.ENABLE_COVERAGE
-        uses: coverallsapp/github-action@v2.3.4
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-
       - name: Build app
         if: inputs.ENABLE_BUILDING
         run: yarn build