Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic tax rate for default tax template in setup wizard #1409

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

ljain112
Copy link
Collaborator

@ljain112 ljain112 commented Dec 15, 2023

2023-12-15_11-10
image

closes: #1190

@ljain112 ljain112 marked this pull request as draft December 15, 2023 05:58
@ljain112 ljain112 force-pushed the fix-dynamic-tax-template branch from 17a2e12 to 0ba79b1 Compare December 15, 2023 06:07
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e2b8f03) 54.75% compared to head (313c47a) 54.88%.
Report is 17 commits behind head on develop.

❗ Current head 313c47a differs from pull request most recent head 01b62e9. Consider uploading reports for the commit 01b62e9 to get more accurate results

Files Patch % Lines
india_compliance/gst_india/overrides/company.py 95.45% 1 Missing ⚠️
india_compliance/setup_wizard.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1409      +/-   ##
===========================================
+ Coverage    54.75%   54.88%   +0.12%     
===========================================
  Files           97       97              
  Lines         7502     7527      +25     
===========================================
+ Hits          4108     4131      +23     
- Misses        3394     3396       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljain112 ljain112 marked this pull request as ready for review December 15, 2023 06:50
@ljain112 ljain112 marked this pull request as draft December 15, 2023 12:23
@ljain112 ljain112 force-pushed the fix-dynamic-tax-template branch from 0ba79b1 to 41b635a Compare December 15, 2023 13:18
@ljain112 ljain112 marked this pull request as ready for review December 15, 2023 13:19
@ljain112 ljain112 force-pushed the fix-dynamic-tax-template branch from 41b635a to b99454a Compare December 15, 2023 13:30
@ljain112 ljain112 force-pushed the fix-dynamic-tax-template branch from b99454a to 313c47a Compare December 15, 2023 13:51
@ljain112 ljain112 requested a review from vorasmit December 15, 2023 14:01
@vorasmit vorasmit merged commit 46407f3 into resilient-tech:develop Dec 19, 2023
9 of 10 checks passed
@vorasmit vorasmit deleted the fix-dynamic-tax-template branch December 19, 2023 10:51
mergify bot pushed a commit that referenced this pull request Dec 19, 2023
mergify bot pushed a commit that referenced this pull request Dec 19, 2023
mergify bot added a commit that referenced this pull request Dec 19, 2023
…tfix/pr-1409

fix: dynamic tax rate for default tax template in setup wizard (backport #1409)
mergify bot added a commit that referenced this pull request Dec 19, 2023
…tfix/pr-1409

fix: dynamic tax rate for default tax template in setup wizard (backport #1409)
india-compliance-bot added a commit that referenced this pull request Dec 22, 2023
# [15.2.0](v15.1.0...v15.2.0) (2023-12-22)

### Bug Fixes

* add zero rated category in transactions for correct reporting ([#1451](#1451)) ([092c513](092c513))
* dynamic tax rate for default tax template in setup wizard ([#1409](#1409)) ([b646c01](b646c01))
* handle GSPGSTDOWN error ([#1423](#1423)) ([f48d109](f48d109))
* handle nil/exempt items in e-Invoice ([#1424](#1424)) ([3ce02d7](3ce02d7))
* update taxable in patch, continue without gst_accounts ([#1438](#1438)) ([a8f03b9](a8f03b9))

### Features

* improved item tax templates ([#227](#227)) ([b373015](b373015))
india-compliance-bot added a commit that referenced this pull request Dec 22, 2023
# [14.21.0](v14.20.2...v14.21.0) (2023-12-22)

### Bug Fixes

* add zero rated category in transactions for correct reporting ([#1451](#1451)) ([6fe41bd](6fe41bd))
* dynamic tax rate for default tax template in setup wizard ([#1409](#1409)) ([2b40810](2b40810))
* handle GSPGSTDOWN error ([#1423](#1423)) ([7fd04e2](7fd04e2))
* handle nil/exempt items in e-Invoice ([#1424](#1424)) ([b5940a9](b5940a9))
* modify params as per erpnext ([4d5e9b4](4d5e9b4))
* remove extra `validate` parameter ([7e8e9d6](7e8e9d6))
* update taxable in patch, continue without gst_accounts ([#1438](#1438)) ([b353086](b353086))

### Features

* improved item tax templates ([#227](#227)) ([ca8a8c6](ca8a8c6))
nabinhait pushed a commit to nabinhait/india-compliance that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Output/Input GST is hardcoded to 18%
2 participants