Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dataset urls to use slug rather than id #107

Merged
merged 2 commits into from
Dec 12, 2017
Merged

Update dataset urls to use slug rather than id #107

merged 2 commits into from
Dec 12, 2017

Conversation

iandenty
Copy link

@iandenty iandenty commented Dec 11, 2017 •
edited
Loading

@iandenty iandenty requested a review from davidsingal December 11, 2017 15:02
@davidsingal
Copy link
Member

Good job! It works perfectly.

@davidsingal davidsingal merged commit b4dbb4f into develop Dec 12, 2017
@davidsingal davidsingal deleted the feature/dataset-slug branch December 12, 2017 10:47
clementprdhomme added a commit that referenced this pull request Dec 12, 2017
@clementprdhomme
Fix a bug that prevent the user to access any dataset
3c8d938 
This is a regression from PR  #107.
@clementprdhomme clementprdhomme mentioned this pull request Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsingal davidsingal Awaiting requested review from davidsingal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iandenty @davidsingal