Adds core datasets location filter #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarrenechea
requested changes
Dec 18, 2017
app/scripts/actions/links.js
Outdated
| @@ -43,6 +44,8 @@ export function updateURL() { | |||
| }); | |||
| } | |||
|
|
|||
| if (locationFilter) query += `&coreDatasetsLocation=${locationFilter}`; | |||
There was a problem hiding this comment.
I think that we should manage the URL with a library (That's a thing that you are always telling me)... https://www.npmjs.com/package/query-string
| @@ -13,7 +14,7 @@ import DatasetsList from '../ui/DatasetsList'; | |||
| import { TABS_OPTIONS } from '../../constants'; | |||
|
|
|||
|
|
|||
| class DataMap extends React.Component { | |||
| class ExploreSidebar extends React.Component { | |||
There was a problem hiding this comment.
Thank you....(I can't believe that DataMap was its previous name)
| .c-dataset-location-filter { | ||
| padding: 0 40px; | ||
|
|
||
| .c-tabs { |
There was a problem hiding this comment.
I think that this should be a theme instead of changing it only at this point
| export const setDatasetsLocation = createThunkAction('datasets/onSetDatasetsLocation', location => | ||
| (dispatch) => { | ||
| dispatch(setLocation(location)); | ||
| dispatch(updateURL()); |
There was a problem hiding this comment.
I don't think that this would be re-usable as long as you are going to always update the URL... Which one? always the explore one? What if you need to update another URL? What if you don't need to update an URL?
| {g.subgroups.map((sg) => { | ||
| const list = data.filter((d) => { | ||
| const locationFilter = isLocationGlobal ? | ||
| true : (((d.vocabulary[0] || {}).attributes || {}).tags || []).includes(location); |
There was a problem hiding this comment.
Bulletproof but illegible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://www.pivotaltracker.com/story/show/153742502