Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a CDI tag to all datasets that are tagged as CDI #20

Merged
merged 3 commits into from
Sep 2, 2016
Merged

Adds a CDI tag to all datasets that are tagged as CDI #20

merged 3 commits into from
Sep 2, 2016

Conversation

sorodrigo
Copy link

This pull request contains:

  • A new title -cdi-tag scss style.
  • Behavior that changes the dataset title class from: "title" to: "title -cdi-tag" if it contains a tag called CDI.

@davidsingal
Copy link
Member

I prefer to use a more general naming for this styles, for example: "-highlighted-tag" or something like that.

@sorodrigo
Copy link
Author

Changed the SCSS style from :after -cdi-tag to a general tag style named -highlighted-tag.

@davidsingal davidsingal merged commit 7bffc51 into develop Sep 2, 2016
@davidsingal davidsingal deleted the feature/CDI-tag branch September 2, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidsingal davidsingal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorodrigo @davidsingal