Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed widget support #225

Merged
merged 3 commits into from
Feb 13, 2018
Merged

Embed widget support #225

merged 3 commits into from
Feb 13, 2018

Conversation

clementprdhomme
Copy link
Contributor

This PR brings support for the embed widgets. The user can embed the map of the NexGDDP tool and the Explore one too.

To test:

  • NexGGDP: go to any NexGDDP dataset and create a new widget from the map, it will appear in My Prep.
  • Explore: create a map with two layers, click the share button and create the widget. It will also appear in My Prep.

From My Prep, you can get the embed link of the two widgets to test it. If you don't want to create widgets, you can see these two working (you need to run the two apps side-by-side locally):

  • NexGDDP: /embed/embed/a7437274-3089-4026-8aaf-5f0cf06763f1
  • Explore: /embed/embed/eaf16acb-3ea1-4a3d-b749-4f622ac594aa

Note tha you won't be able to test properly this PR before these two are merged: resource-watch/prep-manager#65 and resource-watch/prep-manager#66.

Pivotal task 1
Pivotal task 2

@clementprdhomme clementprdhomme self-assigned this Feb 8, 2018
@davidsingal davidsingal merged commit 719881e into develop Feb 13, 2018
@davidsingal davidsingal deleted the feature/embed-widget branch February 13, 2018 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants