Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for MyRWDatasets and DatasetList components #1024

Merged
merged 7 commits into from
Jun 24, 2019

Conversation

pablopareja
Copy link
Contributor

Overview

This PR includes the following fixes and improvements:

  • The component uses now the right service services/dataset instead of the old approach to handle datasets fetching and deletion as part of the MyRW --> datasets section
  • WRISerializer is used now to convert the results from the requests to the appropriate JSON format
  • Pagination toolbar is only shown when there are two or more pages of data
  • Fix for a bug that prevented successfully loading the user datasets after one dataset had been removed

Testing instructions

Go to http://localhost:9000/myrw/datasets/my_datasets

Pivotal task

@agnlez
Copy link
Collaborator

agnlez commented Jun 21, 2019

@pablopareja feel free to merge.

@pablopareja pablopareja merged commit 7d6d0bf into develop Jun 24, 2019
@pablopareja pablopareja deleted the feature/improve-dataset-service-myrw branch June 24, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants