Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1278 #1291

Conversation

PiyushMahore
Copy link

✨ Pull Request

📓 Referenced Issue

Fixes: #1278

ℹ️ About the PR

Added a setTimeout in responsively-app/desktop-app/src/renderer/components/DeviceManager/DeviceDetailsModal.tsx at line number 51
To fix the Custom Device Information Flickering

🖼️ Testing Scenarios / Screenshots

Issue:

Issue

Fixes:

Screen.Recording.2024-08-27.171026.mp4

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

@wp043
Copy link
Contributor

wp043 commented Aug 28, 2024

The title Device Details still flickers to Add a Custom Device.

Comment on lines +51 to +58
setTimeout(() => {
setName('');
setWidth(400);
setHeight(600);
setUserAgent('');
setType('phone');
setDpr(1);
}, 500);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using setTimeout is not a good practice in general, I think that this might be more of a race condition issue. Have you looked at the order of the setStates?

@@ -86,7 +86,7 @@ balanced-match@^1.0.0:
resolved "https://registry.npmjs.org/balanced-match/-/balanced-match-1.0.2.tgz"
integrity sha512-3oSeUO0TMV67hN1AmbXsK4yaqU7tjiHlbxRDZOpH0KW9+CeX4bRAaX0Anxt0tx2MrpRpWwQaPwIlISEJhYU5Pw==

base64id@~2.0.0, base64id@2.0.0:
base64id@2.0.0, base64id@~2.0.0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock should not be updated

@PiyushMahore PiyushMahore closed this by deleting the head repository Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Device Information Flickering
4 participants