Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing TRestAxionXrayWindow using TRestPatternMask #26

Merged
merged 13 commits into from
Jun 9, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented May 30, 2022

jgalan Medium: 135

This PR takes into account the recent TRestPatternMask implementation to redefine the implementation of TRestAxionXrayWindow.

  • The data directory structure has been updated and pipeline as well in consequence.

  • Replaced TRestAxionXrayWIndows metadata members by TRestPatternMask.

  • Documentation updated accordingly.

@jgalan jgalan assigned nkx111 and unassigned nkx111 May 31, 2022
@jgalan jgalan marked this pull request as ready for review May 31, 2022 06:58
@jgalan jgalan requested review from Vindaar, jovoy, ruzarmen and a team May 31, 2022 06:58
Copy link

@ruzarmen ruzarmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I like it! Not sure why we constrain to 8mm radius, there must be a reason for it though.
I am approving the PR

@jgalan
Copy link
Member Author

jgalan commented May 31, 2022

For the moment all definitions are dummy. Once we can build the full setup, we will be able to define any window size through a different RML definition. We will then perform the MonteCarlo with different window sizes, if desired. And with the official window size from Micromegas and InGrid.

@jovoy
Copy link
Contributor

jovoy commented May 31, 2022

Ah yes, the 8mm were just a prototype we were thinking about that is even thinner than the 14mm windows so that's why it's an example here but as Javier said you can put other window parameters in. If you upload the Micromegas window parameters to confluence (or ask someone else to do it) we could also already put it in a RML file.

@jgalan jgalan merged commit 0f9edab into master Jun 9, 2022
@jgalan jgalan deleted the jgalan_metadata_child branch June 9, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants