-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing TRestAxionXrayWindow using TRestPatternMask #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I like it! Not sure why we constrain to 8mm radius, there must be a reason for it though.
I am approving the PR
For the moment all definitions are dummy. Once we can build the full setup, we will be able to define any window size through a different RML definition. We will then perform the MonteCarlo with different window sizes, if desired. And with the official window size from Micromegas and InGrid. |
Ah yes, the 8mm were just a prototype we were thinking about that is even thinner than the 14mm windows so that's why it's an example here but as Javier said you can put other window parameters in. If you upload the Micromegas window parameters to confluence (or ask someone else to do it) we could also already put it in a RML file. |
This PR takes into account the recent
TRestPatternMask
implementation to redefine the implementation ofTRestAxionXrayWindow
.The data directory structure has been updated and pipeline as well in consequence.
Replaced
TRestAxionXrayWIndows
metadata members byTRestPatternMask
.Documentation updated accordingly.