TRestDetectorHitsReadoutAnalysisProcess: Work correctly with multiple hit types #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobis
force-pushed
the
lobis-readout-remove-hits
branch
from
f8ecb72 to
93f42a3
Compare
…or-physics/detectorlib into lobis-readout-remove-hits * 'lobis-readout-remove-hits' of https://github.com/rest-for-physics/detectorlib: (33 commits) class version readout analysis working on veto update class version compute additional observables in readout add check add option to remove hits outside readout comment unused function add gas work function code review [pre-commit.ci] auto fixes from pre-commit.com hooks Get Fano factor from Garfield initialization of efield attempt to unify gas pressure initialization correctly initialize pressure from gas [pre-commit.ci] auto fixes from pre-commit.com hooks TRestDetectorHitsEvent::Sort disabled for MacOs downloads remove debug troubleshoot troubleshoot ...
JPorron
approved these changes
May 7, 2024
mariajmz
approved these changes
May 7, 2024
lobis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the process will add all hits to the output event in order to preserve correctly the event data.
I also added some additional observables.